Skip to content

Conversation

@nordicjm
Copy link
Contributor

@nordicjm nordicjm commented Jun 10, 2024

Adds a sysbuild migration guide and updates documentation

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 10, 2024
@nordicjm nordicjm force-pushed the sb_doc branch 2 times, most recently from 547befc to 0a0c714 Compare June 10, 2024 10:56
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 10, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@40bba76 nrfconnect/sdk-zephyr@b905697 nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nordicjm nordicjm force-pushed the sb_doc branch 3 times, most recently from 3ee5455 to 3ef8582 Compare June 11, 2024 09:12
@NordicBuilder NordicBuilder removed the DNM label Jun 11, 2024
@nordicjm nordicjm force-pushed the sb_doc branch 2 times, most recently from 0d7d39d to a7caab2 Compare June 11, 2024 12:53
@nordicjm
Copy link
Contributor Author

@greg-fer @FrancescoSer could do with a scan through the current content and seeing if anything should be changed. Some of the headings could do with being smaller. https://developer.nordicsemi.com/nRF_Connect_SDK_dev/doc/PR-15845/nrf/config_and_build/sysbuild_migration.html

@nordicjm nordicjm added this to the 2.7.0 milestone Jun 12, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there also some nRF54H20-specific info that should be added? @nordicjm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue, nrf54h20 is out of my scope

@github-actions github-actions bot removed the manifest label Jun 12, 2024
@nordicjm nordicjm force-pushed the sb_doc branch 3 times, most recently from 8784824 to 377b740 Compare June 12, 2024 14:07
@nordicjm
Copy link
Contributor Author

nordicjm commented Jun 25, 2024

I don't agree that this is outside the scope of sysbuild.

Due to some KConfigs becoming sysbuild KConfigs, we have been forced to create duplicate overlays customizing both sysbuild and application Kconfigs for sample build configurations where, previously, only a single overlay sufficed.

Some kind of solution to allow us to return to a single overlay or config value would be greatly appreciated for simplifying build configuration for these samples.

I worked on and pushed for zephyrproject-rtos/zephyr#73254 to be in NCS 2.7 and zephyr 3.7 but I've been pushed back at every turn

Copy link
Contributor

@kapi-no kapi-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Fast Pair part looks good (two nits regarding capitalization)

Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of sysbuild related content on the container page (index.rst) must be fixed.

nordicjm added 18 commits June 25, 2024 10:38
Adds a migration guide of how project features from child/parent
image should be adapted for usage with sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Adds a guide on configuring and using images from sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Adds a page describing how to select a network core image for
zephyr samples

Signed-off-by: Jamie McCrae <[email protected]>
Adds deprecated to the title as this method is deprecated and
replaced with sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Adds sysbuild documentation on configuring bootloaders

Signed-off-by: Jamie McCrae <[email protected]>
Updates instructions to work with sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Fixes alignment of the lines in this file

Signed-off-by: Jamie McCrae <[email protected]>
Updates the documentation for sysbuild and adds listing of Kconfig
options

Signed-off-by: Jamie McCrae <[email protected]>
Updates guides to use sysbuild terms and features

Signed-off-by: Jamie McCrae <[email protected]>
Updates guides to use sysbuild terms and features

Signed-off-by: Jamie McCrae <[email protected]>
Updates usage of a Kconfig for sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Updates usage of a Kconfig for sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Updates usage of a Kconfig for sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Updates file names for sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Fixes a comment on the downgrade page which wrongly states that
the build number would be ignored

Signed-off-by: Jamie McCrae <[email protected]>
Adds a page documenting Kconfig options that sysbuild controls

Signed-off-by: Jamie McCrae <[email protected]>
Re-arranges two Kconfig options for a more natural flow

Signed-off-by: Jamie McCrae <[email protected]>
Adds documentation on configuring a basic firmware loader
application in a project when using sysbuild

Signed-off-by: Jamie McCrae <[email protected]>
Copy link
Contributor

@ludvigsj ludvigsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for Bluetooth Mesh

@anangl anangl merged commit 4c02b2f into nrfconnect:main Jun 25, 2024
@nordicjm nordicjm deleted the sb_doc branch November 6, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc only doc-required PR must not be merged without tech writer approval. manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.